ci/cfengine-build-host-setup.cf: Reformatted with cfengine format#2166
Closed
olehermanse wants to merge 1 commit intocfengine:masterfrom
Closed
ci/cfengine-build-host-setup.cf: Reformatted with cfengine format#2166olehermanse wants to merge 1 commit intocfengine:masterfrom
olehermanse wants to merge 1 commit intocfengine:masterfrom
Conversation
Reformatting this file as a practical test and something to review and discuss. Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
olehermanse
commented
Apr 8, 2026
Comment on lines
+245
to
+250
| "python3-rpm-macros" | ||
| -> | ||
| { | ||
| "provides macro py3_shebang_fix needed in rhel-8 for /var/cfengine/bin/cfbs", | ||
| "ENT-11338" | ||
| } |
Member
Author
There was a problem hiding this comment.
Room for improvement.
olehermanse
commented
Apr 8, 2026
Comment on lines
+208
to
+210
| "xfsprogs"; | ||
| # note that shellcheck, fakeroot and ccache require epel-release to be installed | ||
| # epel-release is installed by distribution package in rhel-7 and by URL for rhel-8+ later in commands section |
Member
Author
There was a problem hiding this comment.
Interesting case, I think the comments should be indented one more level in this case.
olehermanse
commented
Apr 8, 2026
Comment on lines
53
to
73
| "debhelper"; | ||
|
|
||
| "dpkg-dev"; | ||
|
|
||
| "expat"; | ||
|
|
||
| "fakeroot"; | ||
|
|
||
| "flex"; | ||
|
|
||
| "gdb"; | ||
|
|
||
| "libexpat1-dev"; | ||
|
|
||
| "libmodule-load-conditional-perl"; | ||
|
|
||
| "libpam0g-dev"; | ||
|
|
||
| "pkg-config"; | ||
|
|
||
| "psmisc"; |
Member
Author
There was a problem hiding this comment.
We could make it so when there are multiple single line promises in a row, they will not be separated by empty newlines.
Contributor
There was a problem hiding this comment.
yeah, those being next to each other would be much better/easier to read and manage.
olehermanse
commented
Apr 8, 2026
|
|
||
| # I attempted to arrange these packages in order of: generic (all versions) and then as if we gradually added them through time: rhel-6, 7, 8, 9... | ||
| "podman"; | ||
| # I attempted to arrange these packages in order of: generic (all versions) and then as if we gradually added them through time: rhel-6, 7, 8, 9... |
Member
Author
There was a problem hiding this comment.
Indent one more level.
| "libxml2-dev" package_policy => "delete"; | ||
| "librsync-dev" package_policy => "delete"; | ||
| "libattr1-dev" | ||
| package_policy => "delete"; |
Contributor
There was a problem hiding this comment.
I would not prefer these to be on separate lines. Much easier to manage/edit and as-is not that long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reformatting this file as a practical test and something to review and discuss.