Implemented spawn config validation by victormlg · Pull Request #40 · cfengine/cfengine-cli

victormlg · 2026-03-31T09:16:41Z

No description provided.

olehermanse

It's a bit hard to follow the code without seeing the bigger picture, please add:

--validate option which validates the config and won't spawn in the future when that is implemented.
Some shell tests which use the --validate option and prove that it's passing and failing in the right situations.
Some explanation and examples for the feature in the README. Clearly mark it as work in progress.

olehermanse · 2026-04-02T13:11:20Z

README.md

+```yaml
+templates:
+  ubuntu:
+    count: 1


count should be moved to group, not be in template

Templates is not a real key in the final config, all the names defined in templates get expanded before analyzing the config. Ex:

templates: mycfengine: version: 3.27.0 groups: - myhub: role: hub cfengine: mycfengine

Gets turned into:

groups: - myhub: role: hub cfengine: version: 3.27.0

Also, I believe it makes sense to have "count" inside "spawn", Ex:

groups: - client1: role: client source: count: 4 mode: spawn spawn: provider: vagrant vagrant: box: ubuntu/focal64 - client2: role: client source: # count: 4. Here count doesn't make sense, because we have saved hosts mode: save hosts: [ 8.8.8.8 ]

Signed-off-by: Victor Moene <victor.moene@northern.tech>

larsewi · 2026-04-07T11:30:17Z

tests/up-validate/mocks/vagrant

+    exit 0
+fi
+
+echo "Mock Vagrant: Unknown command $@" >&2


Suggested change

echo "Mock Vagrant: Unknown command $@" >&2

echo "Mock Vagrant: Unknown command '$*'" >&2

larsewi · 2026-04-07T11:40:52Z

tests/run-up-validate-tests.sh

@@ -0,0 +1,30 @@
+#/usr/bin/env bash


Suggested change

#/usr/bin/env bash

#!/usr/bin/env bash

larsewi · 2026-04-07T11:55:01Z

src/cfengine_cli/validate.py

+    key = "@{}".format(bootstrap)
+
+    # TODO: Change how to check this if cloud_state.json changes format
+    if key in state and state[key].values()[1]["role"] != "hub":


You probably have to convert the 'dict_values' object to a list before you access it with an index

>>> d = {"a": 1, "b": 2} >>> d.values()[1] Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: 'dict_values' object is not subscriptable >>> list(d.values())[1] 2

larsewi · 2026-04-07T11:56:47Z

src/cfengine_cli/validate.py

+        return
+
+    if remote_download and not is_package_url(package):
+        raise UserError("Package '{}' is not a valid package URL")


There's a format specifier but no arguments

larsewi · 2026-04-07T12:01:58Z

src/cfengine_cli/up.py

+        return self
+
+
+def rgetattr(obj, attr, *args):


Unused function?

larsewi · 2026-04-07T12:06:16Z

src/cfengine_cli/up.py

+
+class GroupConfig(Config):
+    role: Literal["client", "hub"]
+    # "Field" forces pydantic to report errors on the branch defined by the field "provider"


Suggested change

# "Field" forces pydantic to report errors on the branch defined by the field "provider"

# "Field" forces pydantic to report errors on the branch defined by the field "mode"

larsewi · 2026-04-07T12:06:46Z

src/cfengine_cli/up.py

+
+
+class GCPConfig(Config):
+    image: str  # There is no list of avalaible GCP platforms to validate against yet


Suggested change

image: str # There is no list of avalaible GCP platforms to validate against yet

image: str # There is no list of available GCP platforms to validate against yet

larsewi · 2026-04-07T12:07:39Z

README.md


+### Spawn and install cfengine from a config
+
+**this feature is still in work in progress**


Suggested change

**this feature is still in work in progress**

**this feature is still a work in progress**

larsewi · 2026-04-07T12:08:22Z

README.md

+    source: ubuntu
+```
+
+It up will spawn the necessary VMs and install cfengine using cf-remote


Suggested change

It up will spawn the necessary VMs and install cfengine using cf-remote

up will spawn the necessary VMs and install cfengine using cf-remote

larsewi · 2026-04-07T12:09:01Z

tests/up-validate/mocks/cloud_config.json

+  "aws": {
+    "key": "TBD",
+    "secret": "TBD",
+    "key_pair": "TDB",


Suggested change

"key_pair": "TDB",

"key_pair": "TBD",

victormlg force-pushed the spawn-validation branch from 9ff6382 to 0d54ac7 Compare March 31, 2026 09:23

victormlg requested a review from olehermanse March 31, 2026 09:28

victormlg force-pushed the spawn-validation branch from 0d54ac7 to a226367 Compare March 31, 2026 09:32

olehermanse requested a review from larsewi March 31, 2026 20:19

olehermanse requested changes Apr 1, 2026

View reviewed changes

olehermanse reviewed Apr 2, 2026

View reviewed changes

Implemented spawn config validation

6c8683d

Signed-off-by: Victor Moene <victor.moene@northern.tech>

victormlg force-pushed the spawn-validation branch from 548ea20 to 6c8683d Compare April 6, 2026 10:33

victormlg requested a review from olehermanse April 6, 2026 10:36

This was referenced Apr 7, 2026

Design cf-remote config cfengine/cf-remote#165

Closed

CFE-4622: cf-remote idempotent config cfengine/cf-remote#170

Closed

larsewi reviewed Apr 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented spawn config validation#40

Implemented spawn config validation#40
victormlg wants to merge 1 commit intocfengine:mainfrom
victormlg:spawn-validation

victormlg commented Mar 31, 2026

Uh oh!

olehermanse left a comment

Uh oh!

olehermanse Apr 2, 2026

Uh oh!

victormlg Apr 6, 2026 •

edited

Loading

Uh oh!

larsewi Apr 7, 2026

Uh oh!

larsewi Apr 7, 2026

Uh oh!

larsewi Apr 7, 2026

Uh oh!

larsewi Apr 7, 2026

Uh oh!

larsewi Apr 7, 2026

Uh oh!

larsewi Apr 7, 2026

Uh oh!

larsewi Apr 7, 2026

Uh oh!

larsewi Apr 7, 2026

Uh oh!

larsewi Apr 7, 2026

Uh oh!

larsewi Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

	echo "Mock Vagrant: Unknown command $@" >&2
	echo "Mock Vagrant: Unknown command '$*'" >&2

	# "Field" forces pydantic to report errors on the branch defined by the field "provider"
	# "Field" forces pydantic to report errors on the branch defined by the field "mode"



		class GCPConfig(Config):
		image: str # There is no list of avalaible GCP platforms to validate against yet

	image: str # There is no list of avalaible GCP platforms to validate against yet
	image: str # There is no list of available GCP platforms to validate against yet


		### Spawn and install cfengine from a config

		this feature is still in work in progress

	this feature is still in work in progress
	this feature is still a work in progress

	It up will spawn the necessary VMs and install cfengine using cf-remote
	up will spawn the necessary VMs and install cfengine using cf-remote

Conversation

victormlg commented Mar 31, 2026

Uh oh!

olehermanse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victormlg Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

victormlg Apr 6, 2026 •

edited

Loading