Conversation
5e14dbc to
74ee6a7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
- Coverage 83.58% 83.56% -0.02%
==========================================
Files 28 28
Lines 4172 4174 +2
==========================================
+ Hits 3487 3488 +1
- Misses 685 686 +1 |
|
Hm, test results suggest maybe I'm not making the correct check here to resolve this. |
bd4112f to
081043d
Compare
|
Any ideas on how to test both variants in CI? |
0a7a893 to
52f3fe6
Compare
I believe this was a change in openssl 3.2. |
|
Perhaps, it's time to integrate Packit.. |
|
Yup, probably not a bad idea. |
38f1e24 to
7bd302b
Compare
Using OpenSSL 3, the expected error string caught in ssl tests has changed.
E AssertionError: assert 'wrong version number' in
'[SSL] record layer failure (_ssl.c:1000)'
This is already handled for OpenSSL pre-1.1 and gte-1.1, adding handling
for OpenSSL 3+
Fixes: cherrypy#645
7bd302b to
6d0a740
Compare
for more information, see https://pre-commit.ci
Using OpenSSL 3, the expected error string caught in ssl tests has changed.
E AssertionError: assert 'wrong version number' in '[SSL] record layer failure (_ssl.c:1000)'
This is already handled for OpenSSL pre-1.1 and gte-1.1, adding handling for OpenSSL 3+
Fixes: #645
❓ What kind of change does this PR introduce?
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change is