Merged
Conversation
The image tagging operation was never used anywhere in the codebase. Tests reference the image via @image.id directly, not by the tag name. Benefits: - Slightly faster image builds (no tagging overhead) - Cleaner code without unused operations - Reduces confusion about whether tags are needed All tests pass successfully without the tagging operation. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unused Docker image tagging operation that was never referenced anywhere in the codebase.
Changes
Removed this line from
create_image:Analysis
node:20andnode:22were created but never used@image.iddirectlyBenefits
✅ Cleaner code - Removes unused operations
✅ Slightly faster - Avoids unnecessary tagging overhead
✅ Less confusing - Clearer that tags aren't needed
Testing
✅ All tests pass successfully without the tagging
✅ Verified both Node.js 20 and 22 test suites work
✅ Parallel execution still functions correctly
✅ Image cleanup works as expected