-
Notifications
You must be signed in to change notification settings - Fork 426
chore(localizations): Improved french, korean and greek translations #7619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/core-2
Are you sure you want to change the base?
Conversation
Co-authored-by: konstantinosbotonakis <[email protected]>
🦋 Changeset detectedLatest commit: be783d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis pull request adds a changeset entry and updates localization files for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Co-authored-by: anaclumos <[email protected]>
Co-authored-by: gaetanmaisse <[email protected]>
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/localizations/src/el-GR.ts`:
- Line 25: The localization key createdAndExpirationStatus__expiresOn in
el-GR.ts uses the placeholder {{expirationDate}} which doesn't match the
canonical en-US template variable {{expiresDate}}; update the placeholder in
createdAndExpirationStatus__expiresOn from expirationDate to expiresDate so the
interpolation name matches the source template and placeholders render
correctly.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
Community localization improvements built on top of the ff. PRs:
Added PR authors as co-authors and switched base branch to core-2. I'll open another PR pointing to core-3/main.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change