-
Notifications
You must be signed in to change notification settings - Fork 436
fix(clerk-js): Restore backwards compat for legacy clerkUICtor option #7802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 77d6eba The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdds backwards-compatibility handling for legacy Clerk UI constructor options by mapping Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
The legacy clerkUICtor compat code pushed the bundle just over 538KB.
Summary
clerkUICtor/clerkUiCtoroptions that were removed in feat(ui): Add unified ui prop with RSC support via conditional exports #7664#initOptionsmethod now detects legacy option names and converts them to the newui.ClerkUIformatContext
The
uiprop PR (#7664) changed the clerk-js options API fromclerkUICtor(top-level) toui: { ClerkUI }(nested) and removed the backwards compat shim. Consumers still on older SDK versions (e.g. the dashboard) passclerkUICtor, which the new clerk-js ignores — causingassertComponentsReadyto throw "Clerk was not loaded with Ui components" when mounting any component.Failing dashboard smoke tests: https://github.com/clerk/dashboard/actions/runs/21809499309
Test plan
ui.ClerkUItest still passesclerkUICtoroption initializes ClerkUIclerkUiCtoroption initializes ClerkUIpnpm build --filter @clerk/clerk-jspassesSummary by CodeRabbit
Bug Fixes
Tests
Documentation
Chores