Open
Conversation
Add missing definitions, fix a regex bug, and improve framing across the DNS policies folder based on an ELI5 accessibility review.
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
1 similar comment
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Oxyjun
changed the title
Contributor
|
CI run failed: build logs |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves readability and accuracy across all four pages in the DNS policies folder (
src/content/docs/cloudflare-one/traffic-policies/dns-policies/), based on an ELI5 accessibility review.index.mdx— New opening paragraph explains what DNS policies do and why they matter before diving into how Gateway processes queries. Clarifies that 1.1.1.1 is Cloudflare's public DNS resolver.index.mdx— Every selector table references this concept but it was never defined. Added a three-bullet explanation before the Selectors section covering Before/During/After DNS resolution, including why Override cannot use post-resolution selectors.index.mdx— Adds inline context thatArecords are IPv4 andAAAAare IPv6, and explains that0.0.0.0/::are non-routable.index.mdxandcommon-policies.mdx— Expands "EDNS" to "Extension Mechanisms for DNS" on first use and adds a sentence explaining what it does and who sends the data.common-policies.mdx— The phishing policy regex.sso.*was missing the leading*wildcard. Changed to.*sso.*in both the Dashboard table and the API traffic expression to match domains containing "sso" anywhere in the name.test-dns-filtering.mdxprerequisites — Replaces vague "connected to a network" language with specific guidance for WARP vs. DNS-only deployments. Adds context fordig/nslookuptools and explains whatREFUSEDand block page IPs mean indigoutput.test-dns-filtering.mdx— Adds one-sentence definition of ECS before the validation steps.timed-policies.mdx— Opening paragraph now includes example scenarios (work-hours restrictions, temporary access, weekday/weekend differences).timed-policies.mdx— Changes "we will fall back" to "it falls back" per Cloudflare docs style. Adds a note about IP geolocation inaccuracy on VPNs.timed-policies.mdx— Rephrases "retain their duration" to make clear the expiration clock does not pause when a policy is temporarily turned off.