Open
Conversation
Handle http2 GOAWAY error
|
ping @ganey |
Author
hey, what do you need from me? |
|
I haven't looked into this deeply but AFAIK goaway with code 0 means it should shut down after all requests have ended (and responses fully received). Only error codes shut down the socket immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been experiencing the GOAWAY error, it comes in spikes and affects thousands of our users.
We run roughly 9 cloudflared, with 4gb ram, 4cpu each, lowest traffic is around 60 requests/s per cloudflared. We find these GOAWAY errors in the logs when we noticed a huge spike in 524 errors to our users.
Builds on top of this PR #1274