Add --pidfile flag to access tcp command#1579
Open
HueCodes wants to merge 1 commit intocloudflare:masterfrom
Open
Add --pidfile flag to access tcp command#1579HueCodes wants to merge 1 commit intocloudflare:masterfrom
HueCodes wants to merge 1 commit intocloudflare:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
--pidfileflag to thecloudflared access tcpcommand (also applies to the ssh/rdp/smb aliases).When specified, the process writes its PID to the given file path on startup. This makes it much easier to manage the process in scripts and CI/CD pipelines without resorting to fragile pgrep patterns.
Usage looks like:
Tilde expansion is supported for paths like
~/.cloudflared.pid.The implementation follows the same pattern used by the existing
--pidfileflag in the tunnel command, using go-homedir for path expansion and logging errors rather than failing hard if the pidfile can't be written.Closes #723