Merged
Conversation
TheJokr
approved these changes
Apr 2, 2026
foundations includes a feature for memory profiling, which is very useful. Unfortunately, that feature does not natively work with the `jeprof` CLI tool because of the lack of a /pprof/symbol endpoint. Since many Rust binaries are built with PIE, trying to post-hoc symbolize with jeprof/pprof is quite challenging -- especially if running on a remote system that does not have debug symbols available. This commit implements /pprof/symbol, following the golang implementation (https://cs.opensource.google/go/go/+/refs/tags/go1.26.1:src/net/http/pprof/pprof.go;l=197) as a guide. The actual symbolization is performed with the `backtrace` crate, which was previously an indirect dependency and now becomes a direct dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
foundations includes a feature for memory profiling, which is very useful. Unfortunately, that feature does not natively work with the
jeprofCLI tool because of the lack of a /pprof/symbol endpoint. Since many Rust binaries are built with PIE, trying to post-hoc symbolize with jeprof/pprof is quite challenging -- especially if running on a remote system that does not have debug symbols available.This commit implements /pprof/symbol, following the golang implementation
(https://cs.opensource.google/go/go/+/refs/tags/go1.26.1:src/net/http/pprof/pprof.go;l=197) as a guide. The actual symbolization is performed with the
backtracecrate, which was previously an indirect dependency and now becomes a direct dependency.