Open
Conversation
- Match Stratus sidebar dimensions: menu padding, item height, gaps, text sizing, icon offset, transitions - Move px padding from Menu to Content - Match Stratus GroupLabel: grid-rows animation, border separator - Match Stratus Separator: div-based with py-3, inner border-b - Update sidebar width to 16.25rem - Fix caret right-alignment on MenuButtons - Add gap-2 for badge spacing in MenuButton and MenuSubButton - Add cursor-pointer to all clickable sidebar elements - Add before pseudo-element for 1px vertical gap coverage - Restyle SidebarInput to match Stratus search bar - Remove collapsible group path (collapsible prop, GroupContent, collapsible GroupLabel branch) — use Sidebar.Collapsible instead - Update KUMO_SIDEBAR_STYLING.width.expanded to 16.25rem - Remove SidebarCollapsibleGroupDemo and docs section
… demo, clean up exports
Collaborator
|
/bonk review this code |
Contributor
|
@stritt Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
Collaborator
|
/bonk review this code |
commit: |
Contributor
Docs PreviewCommit: |
Contributor
Visual Regression Report14 screenshot(s) with visual changes: Button / Basic83,225 px (44.46%) changed
Button / Variant: Primary68,006 px (40.71%) changed
Button / Variant: Secondary64,552 px (38.64%) changed
Button / Variant: Ghost64,637 px (38.7%) changed
Button / Variant: Destructive67,851 px (40.62%) changed
Button / Variant: Outline64,628 px (38.69%) changed
Button / Variant: Secondary Destructive64,844 px (38.82%) changed
Button / Sizes121,549 px (53.42%) changed
Button / With Icon104,604 px (50.45%) changed
Button / Icon Only81,733 px (43.66%) changed
Button / Loading State108,199 px (52.18%) changed
Button / Disabled State104,660 px (50.47%) changed
Dialog (Open)5,234,939 px (26.14%) changed
Select (Open)1,443,618 px (9.78%) changed
Generated by Kumo Visual Regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
Sidebarcompound component to@cloudflare/kumo— a composable sidebar navigation with collapsible groups, icon-only mode, peeking, resizing, keyboard shortcuts, sliding views, and responsive mobile support.Sub-components
Sidebar.Provider·Sidebar.Root·Sidebar.Header·Sidebar.Content·Sidebar.Footer·Sidebar.Trigger·Sidebar.Group·Sidebar.GroupLabel·Sidebar.GroupContent·Sidebar.Menu·Sidebar.MenuItem·Sidebar.MenuButton·Sidebar.MenuAction·Sidebar.MenuBadge·Sidebar.MenuSub·Sidebar.MenuSubItem·Sidebar.MenuSubButton·Sidebar.Separator·Sidebar.Input·Sidebar.Rail·Sidebar.ResizeHandle·Sidebar.MenuChevron·Sidebar.Collapsible·Sidebar.CollapsibleTrigger·Sidebar.CollapsibleContent·Sidebar.SlidingViews·Sidebar.SlidingViewFeatures
collapsiblemode (icon,offcanvas,none)minWidth/maxWidthand auto-collapse thresholdkeyboardShortcutprop (e.g.mod+b), exposed in trigger tooltipSidebar.CollapsibleandSidebar.GroupwithdefaultOpensupportMenuButtontooltips auto-show when sidebar is collapsedsideprop on Provideraria-expanded,aria-keyshortcuts, and tooltipDocs
/components/sidebarwith 9 interactive demos: Basic, Collapsible Groups, Toggle, Full (kitchen sink), Resizable, Right Side, Peeking, Keyboard Shortcut, Sliding ViewsValidation
pnpm typecheck— 0 errors (bothkumoandkumo-docs-astro)pnpm --filter @cloudflare/kumo test— 708 tests pass (39 sidebar-specific)pnpm lint— 0 new errors (1 pre-existingno-noninteractive-element-interactionson<aside>)No breaking changes
New component addition. No existing APIs modified.