fix(dropdown): add scroll behavior for long lists#352
Draft
mattrothenberg wants to merge 1 commit intomainfrom
Draft
fix(dropdown): add scroll behavior for long lists#352mattrothenberg wants to merge 1 commit intomainfrom
mattrothenberg wants to merge 1 commit intomainfrom
Conversation
- Add max-h-[var(--available-height)] to constrain popup to viewport - Add inner scroll container with overflow-y-auto and overscroll-contain - Add docs demo with max-height toggle to exercise scroll behavior - Matches Base UI's Combobox scroll pattern
commit: |
Contributor
Docs PreviewCommit: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.













































Summary
max-h-[var(--available-height)]to constrain dropdown popup to available viewport spaceoverflow-y-autoandoverscroll-containto handle long listsPattern
Follows Base UI's Combobox scroll pattern:
This ensures the background stays on the non-scrolling frame, preventing transparency during overscroll.
Testing
Note
Short dropdowns (< 3 items) may have subtle rubber-banding when attempting to scroll. This is a minor side effect of having a scroll container and is acceptable behavior.