Always invoke bazel build for prettier (fix lint)#5979
Open
Conversation
We recently updated the prettier version which breaks linting if an older cached version is used on a PR. This PR is a quick dirty fix that always tells Bazel to build prettier before we use it. It won't waste time to rebuild it if unneeded, but it will add a check that slows things down cause Bazel. If we're fine with this solution, I'll change all the linters. If not, I'll revert it and implement the solution we decide on, but we need to unscrew the build for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently updated the prettier version which breaks linting if an older cached version is used on a PR.
This PR is a quick dirty fix that always tells Bazel to build prettier before we use it. It won't waste time to rebuild it if unneeded, but it will add a check that slows things down cause Bazel.
If we're fine with this solution, I'll change all the linters. If not, I'll revert it and implement the solution we decide on, but we need to unscrew the build for now.