Skip to content

enable fn_params_excessive_bools clippy rule#6387

Merged
anonrig merged 1 commit intomainfrom
yagiz/enable-rust-fn-max-bools
Mar 24, 2026
Merged

enable fn_params_excessive_bools clippy rule#6387
anonrig merged 1 commit intomainfrom
yagiz/enable-rust-fn-max-bools

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Mar 23, 2026

Ref: #6360 (comment)

This rule forces every bool argument to be converted into enum. We might want to enable this, or not...

@anonrig anonrig requested a review from jasnell March 23, 2026 17:01
@anonrig anonrig requested review from a team as code owners March 23, 2026 17:01
@anonrig anonrig requested review from guybedford and mikea March 23, 2026 17:01
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 23, 2026

The PR is clean. Let me verify: the changes enable the fn_params_excessive_bools clippy lint, set max-fn-params-bools = 0 (meaning no bool parameters allowed at all), and properly suppress the lint with #[expect(...)] and clear reason strings at the three locations where bool parameters are dictated by the C++ FFI interface. The exploration confirmed there are no other functions in the Rust codebase (outside tests) that take bare bool parameters, so no other locations need suppression.

The #[expect] is correctly used instead of #[allow] (per project convention), the reason strings are clear and accurate, and the module-level suppression on pub mod ffi is appropriate since the CXX bridge functions have signatures dictated by the C++ side.

No actionable issues found.

LGTM

github run

@anonrig anonrig merged commit 390cf7d into main Mar 24, 2026
25 of 26 checks passed
@anonrig anonrig deleted the yagiz/enable-rust-fn-max-bools branch March 24, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants