You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR is clean. Let me verify: the changes enable the fn_params_excessive_bools clippy lint, set max-fn-params-bools = 0 (meaning no bool parameters allowed at all), and properly suppress the lint with #[expect(...)] and clear reason strings at the three locations where bool parameters are dictated by the C++ FFI interface. The exploration confirmed there are no other functions in the Rust codebase (outside tests) that take bare bool parameters, so no other locations need suppression.
The #[expect] is correctly used instead of #[allow] (per project convention), the reason strings are clear and accurate, and the module-level suppression on pub mod ffi is appropriate since the CXX bridge functions have signatures dictated by the C++ side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #6360 (comment)
This rule forces every
boolargument to be converted intoenum. We might want to enable this, or not...