Conversation
Yavor16
force-pushed
the
adopt-azure-sdk
branch
3 times, most recently
from
8abfeec to
0f289a1
Compare
karrgov
reviewed
Mar 4, 2026
.../org/cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorage.java
Show resolved
Hide resolved
...oundry/multiapps/controller/web/configuration/service/ObjectStoreServiceInfoCreatorTest.java
Outdated
Show resolved
Hide resolved
vkalapov
requested changes
Mar 6, 2026
.../cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorageTest.java
Outdated
Show resolved
Hide resolved
...y/multiapps/controller/web/configuration/bean/factory/ObjectStoreFileStorageFactoryBean.java
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
Comment on lines
+156
to
+166
| public String getContainerUriEndpoint(Map<String, Object> credentials) { | ||
| if (!credentials.containsKey(CONTAINER_URI)) { | ||
| return null; | ||
| } | ||
| try { | ||
| URL containerUri = new URL((String) credentials.get(CONTAINER_URI)); | ||
| return new URL(containerUri.getProtocol(), containerUri.getHost(), containerUri.getPort(), "").toString(); | ||
| } catch (MalformedURLException e) { | ||
| throw new IllegalStateException(Messages.CANNOT_PARSE_CONTAINER_URI_OF_OBJECT_STORE, e); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
It looks like this method is only referenced by a protected method within the same class. Should we consider reducing its visibility from public to protected?
Contributor
Author
There was a problem hiding this comment.
I made it public so I can test it better using unit tests.
...oudfoundry/multiapps/controller/web/configuration/service/ObjectStoreServiceInfoCreator.java
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorage.java
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorage.java
Show resolved
Hide resolved
.../org/cloudfoundry/multiapps/controller/persistence/services/AzureObjectStoreFileStorage.java
Outdated
Show resolved
Hide resolved
Yavor16
force-pushed
the
adopt-azure-sdk
branch
from
0f289a1 to
eb3c751
Compare
IvanBorislavovDimitrov
previously approved these changes
Mar 11, 2026
vkalapov
previously approved these changes
Mar 12, 2026
karrgov
approved these changes
Mar 12, 2026
# Conflicts: # pom.xml
Yavor16
dismissed stale reviews from vkalapov and IvanBorislavovDimitrov
via
f1d5b2d
Yavor16
force-pushed
the
adopt-azure-sdk
branch
from
eb3c751 to
f1d5b2d
Compare
|
vkalapov
approved these changes
Mar 18, 2026
IvanBorislavovDimitrov
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.