Example implementation of variables#124
Open
Epitrochoid wants to merge 1 commit intocloudhead:masterfrom
Open
Conversation
Owner
|
Yeah that's a good start! To generalize it so it can be used anywhere I guess you would define a |
Owner
|
Actually that would only work for "static" variables ... variables that change over the course of the program will need to be treated differently, and for doing something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a quick spike of one of the ideas from issue #120. This is a pretty limited example since it only supports using a setting as a variable in a
Setcall.set grid/color = &backgroundor similar works with these changes.Is this a direction worth pursuing? To be useful for #120 it would in the very least need to cover referencing a setting's value in any command (allowing selection movement to be based on grid size). Adding code to each and every command doesn't seem tenable, but I'm fairly sure that mapping over the
cmdargument infn command(session.rs) and resolving anyValue::vars would be doable.Additionally I didn't tackle tuple destructuring support here. I'm thinking the easiest solution would be to allow tuple values to access by index as
&grid/spacing.0or possibly&grid/spacing.first.