Skip to content

Development #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
fwiesel wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Development #221

fwiesel wants to merge 4 commits into from

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Jan 15, 2026

No description provided.

fwiesel added 4 commits January 8, 2026 14:19
@fwiesel
Use the Hypervisor CRD instead of labels.
10bebbd 
When there is no maintenance-contoller profile the GardenerLifecycleController
will now set the hypervisor cro maintenance field.
For confirmation, it will look on the conditions.
That renders the labels obsolete.
@fwiesel
Offboarding via Hypervisor CRO
c822237 
- Block gardener with pdb until offboarded
- Communicate offboarded via condition on hypervisor
- Do only decomissioning via hypervisor cro

Use offboarded instead of decomissioning as it
is clearer the opposite from onboarding.
@fwiesel
DecomissionController: Wait for eviction condition
8080f67 
It doesn't make sense to poll openstack for the hypervisors, when
we are still evicting.
@fwiesel
EvictionController: Drop disabling of hypervisor
9d3bb74
@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 56.46% (+4.84%) 👍
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd/main.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/decomission_controller.go 55.56% (-2.89%) 63 (-14) 35 (-10) 28 (-4) 👎
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/eviction_controller.go 30.56% (-7.17%) 144 (-76) 44 (-39) 100 (-37) 👎
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller.go 75.81% (+62.25%) 62 (+3) 47 (+39) 15 (-36) 🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/node_eviction_label_controller.go 0.00% (-40.54%) 0 (-74) 0 (-30) 0 (-44) 💀 💀 💀 💀
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/utils.go 73.91% (+1.36%) 46 (-5) 34 (-3) 12 (-2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/decomission_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/eviction_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/node_eviction_label_controller_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fwiesel