CORSFilter.java: allow port 9000 for interop with react HMR#405
CORSFilter.java: allow port 9000 for interop with react HMR#405
Conversation
|
So I did the easy part just to get the ball rolling, but now the hard part: how do I test this? 🙈 |
|
Not sure if these are 100% up to date, but are you able to get local javabuilder running using these instructions? |
|
Actually, I'm confused b/c the Slack discussion is talking about a deployed Javabuilder instance, and |
|
I'm confused enough that I'm not 100% sure if I'm confused or not... but this might clarify. It sounds to me like Molly is proposing we deploy a new dev instance to lambda, and test using that? Testing instructions from mollyMolly slacked me these instructions on testing, but I haven't done it yet:
|
|
Cool yeah I think Molly's instructions are the one you want, ignore my suggestion! |
We enabled react hot module replacement (code-dot-org/code-dot-org#56882), which uses the react devserver. This proxies requests from port 9000 to port 3000, which means the browser's origin will be port 9000. This means we expect to see valid requests to Javabuilder originating from port 9000.
This PR updates the CORSFilter's ALLOWED_ORIGINS.