fix(utils): prevent race condition in parallel plugin runs #1222
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the same plugin for multiple projects in parallel (e.g., via Nx targets), the timestamp-based directory naming could collide if two processes started within the same millisecond. This caused one process to delete the output directory while another was still using it, leading to failures. The fix adds process.pid and a random suffix to the directory name, ensuring uniqueness even when multiple processes run simultaneously.
|
View your CI Pipeline Execution ↗ for commit 4e24f73
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Contributor
Code PushUp😟 Code PushUp report has regressed – compared current commit 1d7ffda with previous commit 1d7ffda. 🏷️ Categories
👎 1 group regressed, 👎 5 audits regressed, 11 audits changed without impacting score🗃️ Groups
33 other groups are unchanged. 🛡️ Audits
663 other audits are unchanged. |
Contributor
vmasek
approved these changes
Jan 19, 2026
BioPhoton
requested changes
Jan 19, 2026
| // Use timestamp + process ID + random suffix to ensure uniqueness | ||
| // This prevents race conditions when running the same plugin for multiple projects in parallel | ||
| // eslint-disable-next-line @typescript-eslint/no-magic-numbers | ||
| const uniqueId = `${Date.now()}-${process.pid}-${Math.random().toString(36).slice(2, 8)}`; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const uniqueId = `${Date.now()}-${process.pid}-${Math.random().toString(36).slice(2, 8)}`; | |
| const uniqueId = `${(performance.timeOrigin+performance.now())*10}-${process.pid}-${threadId}`; |
- We can get an additional digit from
perf_hookswhich is also monotonic:(performance.timeOrigin+performance.now())*10 - Processes can have multiple threads
threadIdis0by default
Contributor
Author
There was a problem hiding this comment.
That's why there is a random suffix. Imo, process + suffix is good enough, but I'll let the rest of the team confirm that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition when running the same plugin for multiple projects in parallel (e.g., via Nx targets).
Problem
When two processes started within the same millisecond, the timestamp-based directory naming in
createRunnerFileswould collide:This caused one process to delete the output directory (in
executeRunnerConfig) while another was still using it, leading to failures.Solution
Added
process.pidand a random suffix to the directory name to ensure uniqueness:This ensures that even when multiple processes run simultaneously, each gets its own unique working directory.