Skip to content

Correct TypeScript type definitions for effect functions #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DenysKuchma wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Correct TypeScript type definitions for effect functions #5395

DenysKuchma wants to merge 1 commit into from
+3 −3

Conversation

@DenysKuchma
Copy link
Collaborator

@DenysKuchma DenysKuchma commented Jan 16, 2026

#5205

Changes:

  • TryTo: now correctly returns Promise instead of Promise<T | false>
  • HopeThat: now correctly returns Promise instead of Promise<T | false>
  • RetryTo: now accepts (fn: (tries: number) => Promise | void, maxTries: number, pollInterval?: number) and returns Promise

@DenysKuchma DenysKuchma requested a review from DavertMik January 16, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DenysKuchma