Skip to content

feat: allow bedrock base url definition #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dannykopping merged 2 commits into from
Jan 21, 2026
Merged

feat: allow bedrock base url definition #131

dannykopping merged 2 commits into from
Jan 21, 2026

Conversation

@dannykopping
Copy link
Collaborator

@dannykopping dannykopping commented Jan 20, 2026

Partially addresses #126

@dannykopping dannykopping mentioned this pull request Jan 20, 2026
Merged
ssncferreira
ssncferreira approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@ssncferreira ssncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 just a question, what happens if the user configures both a Region and a BaseURL for Bedrock? My guess is that the BaseURL takes precedence (since it's appended last to opts. Maybe, a test validating the precedence behavior would be helpful, wdyt?

@dannykopping
chore: review feedback
b73304a 
Signed-off-by: Danny Kopping <[email protected]>
@dannykopping
Copy link
Collaborator Author

dannykopping commented Jan 21, 2026 •
edited
Loading

LGTM 👍 just a question, what happens if the user configures both a Region and a BaseURL for Bedrock? My guess is that the BaseURL takes precedence (since it's appended last to opts. Maybe, a test validating the precedence behavior would be helpful, wdyt?

Fair question @ssncferreira, it was already implicitly doing this in bridge_integration_test.go but now I've made it explicit.
I've also cleaned up some other tests and added reasoning why we can't unit test this in b73304a.

@dannykopping dannykopping merged commit e164b50 into main Jan 21, 2026
1 check passed
dannykopping added a commit to coder/coder that referenced this pull request Jan 21, 2026
@dannykopping
feat: support custom bedrock base url (#21582)
a14a22e 
Closes coder/aibridge#126
Depends on coder/aibridge#131

---------

Signed-off-by: Danny Kopping <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssncferreira ssncferreira ssncferreira approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dannykopping @ssncferreira