feat: add DangerousDisableCoderSignatureValidation UserDefault to skip tunnel binary codesign check#241
Open
ethanndickson wants to merge 4 commits intomainfrom
Open
feat: add DangerousDisableCoderSignatureValidation UserDefault to skip tunnel binary codesign check#241ethanndickson wants to merge 4 commits intomainfrom
ethanndickson wants to merge 4 commits intomainfrom
Conversation
Member
Author
|
@codex review |
ethanndickson
changed the title
disableDownloadSignatureValidation UserDefault to skip tunnel binary signature check
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50d89986f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ethanndickson
force-pushed
the
vpn-config-ddjz
branch
from
50d8998 to
a4f0ef0
Compare
ethanndickson
changed the title
disableDownloadSignatureValidation UserDefault to skip tunnel binary signature check
ethanndickson
force-pushed
the
vpn-config-ddjz
branch
from
a4f0ef0 to
94fd28e
Compare
…p tunnel binary codesign check
ethanndickson
force-pushed
the
vpn-config-ddjz
branch
from
94fd28e to
606eb3a
Compare
ethanndickson
changed the title
deansheather
approved these changes
Mar 6, 2026
- Shorten local variable name in PacketTunnelProvider.swift to keep line under 120 chars - Add function_parameter_count disable comments for startDaemon in XPC.swift and HelperXPCListeners.swift - Add cyclomatic_complexity to existing disable comment in Manager.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
DangerousDisableCoderSignatureValidationUserDefaults key (MDM-settable) that disablesSecStaticCodesignature validation of the downloaded tunnel binary, mirroring the Windows app'sManager:TunnelBinarySignatureSignerregistry key.The setting flows through the existing pipeline:
When enabled, signature validation is skipped with a warning log. Version validation is always performed.
Closes #240, where a user would like to user Coder Desktop alongside a Coder deployment built from source.
Usage
defaults write com.coder.Coder-Desktop DangerousDisableCoderSignatureValidation -bool trueor, like all UserDefaults, can be configured via your MDM platform to apply this rule to an entire org.
Then restart the app, and log out and back in.
Files changed
State.swift— new UserDefaults key + providerConfiguration plumbingPacketTunnelProvider.swift— reads flag, forwards to XPCVPNLib/XPC.swift— updatedHelperNEXPCInterface.startDaemonsignatureNEHelperXPCClient.swift— updated XPC client wrapperHelperXPCListeners.swift— updated XPC server implementationManager.swift— newManagerConfigfield + conditional skip inManager.init