🤖 feat: enable mux testing mux via isolated roots#1614
🤖 feat: enable mux testing mux via isolated roots#1614ibetitsmike wants to merge 9 commits intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 407860156b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed the port-collision concern by clearing |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd2815c062
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Also updated |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 044e5238d0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Also updated test-instance spawning to override |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5535769fe5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
856ced7 to
53c28cb
Compare
53c28cb to
f2a478a
Compare
This enables running multiple mux desktop instances on the same machine without collisions by scoping both mux state and Electron
userDataper root.What changed
--mux-root <path>(alias--root) that setsMUX_ROOTearly and strips itself from argv for subcommand routing.userDatafrom the chosen mux root (<muxHome>/user-data) so the single-instance lock + localStorage are effectively per-root.~/.cmux → ~/.mux) is skipped when using a custom root to avoid side effects.mux-testing-mux.<muxHome>/instances/<id>and spawns a new mux process with--mux-root)How to use
mux --mux-root /tmp/mux-test-1Debug: Launch Test InstanceValidation
make static-checkGenerated with
mux• Model: openai:gpt-5.2 • Thinking: xhigh • Cost: $14.25