feat: fall back to extension storage for proxy log directory#827
Open
feat: fall back to extension storage for proxy log directory#827
Conversation
When coder.proxyLogDirectory is not configured, use the extension's global storage log path instead of discarding logs. This makes troubleshooting easier without requiring manual configuration.
Covers configured path, empty/whitespace/unset fallback to default, and tilde expansion.
…olution Add CODER_SSH_LOG_DIR env var fallback for proxy log directory, apply expandPath consistently to both settings and env vars in getBinaryCachePath and getProxyLogPath, and inline the removed getLogPath method.
EhabY
force-pushed
the
feat/proxy-log-fallback-storage
branch
from
e839d13 to
c6b015e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getProxyLogPath) so logs are always written even whencoder.proxyLogDirectoryis not explicitly configured, removing the "No logs available" dead-end in the UICODER_SSH_LOG_DIRenvironment variable support as an intermediate fallback (setting > env var > extension storage)resolveOverridehelper inPathResolverthat bothgetBinaryCachePathandgetProxyLogPathuse, ensuring consistent trim, tilde/${userHome}expansion, and normalization for all path overridescommands.tslog viewer to always use the resolved log directory instead of branching on whether the setting is configuredCloses #824