Refactor container_list_windows_test.go to use Tigron#4643
Open
Deepam02 wants to merge 1 commit intocontainerd:mainfrom
Open
Refactor container_list_windows_test.go to use Tigron#4643Deepam02 wants to merge 1 commit intocontainerd:mainfrom
Deepam02 wants to merge 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: Deepam Goyal <deepam02goyal@gmail.com>
46 tasks
Member
|
CI seems failing |
haytok
reviewed
Dec 11, 2025
Comment on lines
+139
to
+145
| testCase.Require = &test.Requirement{ | ||
| Check: func(_ test.Data, _ test.Helpers) (bool, string) { | ||
| if !testutil.HyperVSupported() { | ||
| return false, "HyperV is not enabled, skipping test" | ||
| } | ||
| return true, "" | ||
| }, |
Member
There was a problem hiding this comment.
IMO, better to use this variable:
Comment on lines
+79
to
+80
| // Wait for container to start - using polling | ||
| helpers.Ensure("exec", testContainerName, "echo", "ready") |
Member
There was a problem hiding this comment.
Is there a reason you're using helpers.Ensure instead of nerdtest.EnsureContainerStarted ?
Comment on lines
+153
to
+158
| inspectOutput := helpers.Capture("inspect", containerName, "--format", "json") | ||
|
|
||
| var inspect []dockercompat.Container | ||
| err := json.Unmarshal([]byte(inspectOutput), &inspect) | ||
| assert.NilError(helpers.T(), err, "failed to unmarshal inspect output") | ||
| assert.Assert(helpers.T(), len(inspect) > 0, "expected at least one container in inspect output") |
Member
There was a problem hiding this comment.
Can we use nerdtest.InspectContainer function to get nerdctl inspect <container name> result?
Member
|
ping @Deepam02 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates tests to use nerdtest.Setup and the Tigron testing framework, #4613.
Sorry for the delay, I was having trouble running the tests locally and have solved it partly now. If this looks good, I can pick up more test files.