Fix phpstan failure in ApiExtension config assertion#31
Merged
f3l1x merged 1 commit intocontributte:masterfrom Feb 12, 2026
Merged
Fix phpstan failure in ApiExtension config assertion#31f3l1x merged 1 commit intocontributte:masterfrom
f3l1x merged 1 commit intocontributte:masterfrom
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
ohmyfelix
force-pushed
the
fix/phpstan-assert-input-type
branch
from
741d601 to
ddf6bc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mixedvalue intostr_starts_with,class_exists, andinterface_existsinside the config schema assertion.is_string()guard inApiExtension::getConfigSchema()so the assertion remains safe and statically provable.make qa,make tests, andmake coverage.