Added dynamic parameter ability to version#85
Merged
f3l1x merged 1 commit intocontributte:masterfrom Feb 12, 2026
Merged
Conversation
Member
|
Seems good to me, fix CI and I will merge it |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 98.91% 96.03% -2.88%
==========================================
Files 3 3
Lines 92 101 +9
==========================================
+ Hits 91 97 +6
- Misses 1 4 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@f3l1x Hello, should be done. |
Member
|
Thx bro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am keeping my app version inside version.json that is created from git directly on each deploy. I would appreciate ability to set CLI version using dynamic call to a static method which can fetch this value.
I made these changes. Tell me if I forgot something.
Please check the "addSetup" code as I am not sure if it handles every possibility as it should.