Merged
Conversation
Replace phpdbg with php in the Makefile coverage target to match the org-wide coverage migration tracked in #73.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
=========================================
Coverage ? 87.61%
=========================================
Files ? 26
Lines ? 444
Branches ? 0
=========================================
Hits ? 389
Misses ? 55
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-p phpdbgwith-p phpin thecoveragetarget ofMakefileMotivation
phpdbgis being removed from Contributte coverage targets, so this repo should use the regular PHP binary for coverage runs insteadChanges
coveragetarget variants inMakefileto invoke Tester with-p phpTesting
make coverageattempted locallymake testsattempted locallyLocal blockers:
make coveragefails because this environment does not have Xdebug, PCOV, or PHPDBG available for coverage collection when usingphpmake testsfails intests/Cases/File.phptbecause the GD extension is not loaded in this environmentCloses #73