Skip to content

Use php in coverage target#45

Merged
f3l1x merged 1 commit intocontributte:masterfrom
ohmyfelix:chore/remove-phpdbg-coverage
Mar 17, 2026
Merged

Use php in coverage target#45
f3l1x merged 1 commit intocontributte:masterfrom
ohmyfelix:chore/remove-phpdbg-coverage

Conversation

@ohmyfelix
Copy link
Contributor

Summary

  • replace -p phpdbg with -p php in the coverage target of Makefile
  • align this repository with the org-wide coverage migration tracked in #73

Motivation

  • phpdbg is being removed from Contributte coverage targets, so this repo should use the regular PHP binary for coverage runs instead

Changes

  • update both coverage target variants in Makefile to invoke Tester with -p php

Testing

  • make coverage attempted locally
  • make tests attempted locally
  • CI passes

Local blockers:

  • make coverage fails because this environment does not have Xdebug, PCOV, or PHPDBG available for coverage collection when using php
  • make tests fails in tests/Cases/File.phpt because the GD extension is not loaded in this environment

Closes #73

Replace phpdbg with php in the Makefile coverage target to match the org-wide coverage migration tracked in #73.
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@9dfc930). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #45   +/-   ##
=========================================
  Coverage          ?   87.61%           
=========================================
  Files             ?       26           
  Lines             ?      444           
  Branches          ?        0           
=========================================
  Hits              ?      389           
  Misses            ?       55           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@f3l1x f3l1x marked this pull request as ready for review March 17, 2026 17:14
@f3l1x f3l1x merged commit 64a77e1 into contributte:master Mar 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants