Full dependency audit, chores and fixes Rust and JS #381
Open
Cristian-Vogel wants to merge 27 commits intocrabnebula-dev:mainfrom
Open
Full dependency audit, chores and fixes Rust and JS #381Cristian-Vogel wants to merge 27 commits intocrabnebula-dev:mainfrom
Cristian-Vogel wants to merge 27 commits intocrabnebula-dev:mainfrom
Conversation
* jsdom (transitive form-data 4.0.0)
* eslint-config-prettier * eslint-plugin-solid
* @sentry/vite-plugin (transients:* @sentry/bundler-plugin-core -> glob, whatwg-encoding) * eslint-plugin-solid
* @sentry/vite-plugin (transients:* @sentry/bundler-plugin-core -> glob, whatwg-encoding) * eslint * @typescript-eslint/eslint-plugin and @typescript-eslint/parser
npm , weekly
…abot-setup Create dependabot.yml
cargo packages only
Cristian/audit
Cristian/audit
* update formatters test because "00:00:00" is now the standard representation for the start of a day in a 24-hour clock * migrate to eslint.config.js usage
* it's 5000 lines of fake monitor data for testing, was generating 2300 warnings after eslint upgrade
This change completes the migration to ESLint v9 and addresses several build and linting issues introduced by recent dependency updates.
#### Highlights:
* **ESLint v9 Flat Config Migration**: Successfully transitioned from `.eslintrc.json` to the new `eslint.config.js` format.
* **Dependency Updates**: Added required ESLint v9 packages (`@eslint/js`, `globals`, `typescript-eslint`, etc.) to `clients/web/package.json`.
* **Build Fixes**: Updated `shiki` asset paths in `vite.config.ts` to match the new package structure in v1.29.2, resolving a critical build failure in `vite-plugin-static-copy`.
* **Code Quality & Linting**: Fixed over 21 linting errors and warnings, including:
* Addressing `no-unassigned-vars` for SolidJS `ref` variables by adjusting the ESLint configuration.
* Cleaning up unused `eslint-disable` directives and redundant non-null assertions.
* Standardizing `_` prefixing for unused variables in `catch` blocks.
* Implementing the `preserve-caught-error` rule by adding `cause` to re-thrown errors.
* **Performance & Noise Reduction**: Added `dist/` and `src/lib/proto/` to ESLint ignores to prevent linting minified bundles and generated code.
The project now passes both `pnpm build` and `pnpm lint` without errors.
👷 Deploy request for cn-devtools-app pending review.Visit the deploys page to approve it
|
Cristian-Vogel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers a series of dependency maintenance tasks, security updates, and a major migration of the linting infrastructure.
Summary of Changes
Major Dependency Upgrades:
@typescript-eslint/eslint-plugin,@typescript-eslint/parser, and associated plugins (eslint-plugin-solid,eslint-config-prettier).@protobuf-ts/*packages to v2.11.1.Infrastructure & Configuration:
pnpm-workspace.yamlto manage dependencies acrossclients/webandexamples/consistently.dependabot.ymlconfiguration to automate future dependency security audits and updates.eslint.config.js).Build & Code Quality Fixes:
vite.config.tsasset paths to accommodate breaking changes inshikiv1.29.2.no-unassigned-varsfor SolidJS refs, unused variables in catch blocks).ignoreslist to exclude generated files (src/lib/proto/,monitor-data.ts) and build artifacts from linting.Commit History Highlights (since
2fd3ce7)f8eebf3: Initialpnpm updaterun.106a615: Critical dependency bumps (jsdom/form-data).3f2f89c: Setup ofpnpm-workspace.89899c7: Final ESLint v9 migration, build fixes, and code cleanup.