Skip to content

Conversation

@AmarTrebinjac
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac commented Jan 18, 2026

Changes

Simple profile view widget showing views by week, month and total
Screenshot 2026-01-19 at 09 45 39

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://eng-362.preview.app.daily.dev

@vercel
Copy link

vercel bot commented Jan 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
daily-webapp Ready Ready Preview Jan 23, 2026 3:03pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
storybook Ignored Ignored Jan 23, 2026 3:03pm

Request Review

Comment on lines 106 to 115
...(!!referrerPost && {
extra: JSON.stringify({
referrer_target_id: referrerPost.id,
referrer_target_type: TargetType.Post,
author: user?.id && referrerPost.author?.id === user.id ? 1 : 0,
}),
}),
});
setTrackedView(true);
}, [user, trackedView, logEvent, referrerPost]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be reverted

@AmarTrebinjac
Copy link
Contributor Author

@claude Please undo the change @capJavert mentions above here.

@claude
Copy link
Contributor

claude bot commented Jan 23, 2026

Claude finished @AmarTrebinjac's task in 1m 23s —— View job


Reverted the change ✓

Tasks

  • Read the file to understand the current state
  • Check git diff to see what changed
  • Revert the change at line 115
  • Commit and push the changes

Summary

I've successfully reverted the change that @capJavert mentioned. The PR had removed the usePostReferrerContext import and its usage from the ProfileLayout component, which eliminated the referrer tracking logic from the ProfileView event.

Changes made:

  • Restored TargetType import from @dailydotdev/shared/src/lib/log
  • Restored usePostReferrerContext import
  • Added back the referrerPost hook usage
  • Restored the referrer tracking logic in the ProfileView event (includes referrer_target_id, referrer_target_type, and author fields)
  • Added referrerPost back to the useEffect dependency array

The file packages/webapp/components/layouts/ProfileLayout/index.tsx has been reverted to its original state, and the changes have been pushed to the ENG-362 branch.


Branch: ENG-362 |

This reverts the removal of usePostReferrerContext and associated
referrer tracking logic from the ProfileView event.

Co-authored-by: Amar Trebinjac <[email protected]>
@AmarTrebinjac AmarTrebinjac enabled auto-merge (squash) January 23, 2026 15:05
@AmarTrebinjac AmarTrebinjac merged commit e03203e into main Jan 23, 2026
11 checks passed
@AmarTrebinjac AmarTrebinjac deleted the ENG-362 branch January 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants