feat(comments): collapse sub-comments by default with expand preview by dailydotdevbot · Pull Request #5420 · dailydotdev/apps

dailydotdevbot · 2026-01-30T13:46:35Z

Summary

Sub-comments (replies) are now collapsed by default showing a preview with up to 3 overlapping user avatars and a "View X replies" link
Clicking the preview expands to show all replies
Main/parent comments remain fully visible - only nested replies collapse

Closes ENG-515

Created by Huginn 🐦‍⬛

Preview domain

https://eng-515-comments-expanded-by-def.preview.app.daily.dev

Sub-comments (replies) are now collapsed by default and show a preview with up to 3 overlapping user avatars and a "View X replies" link. Clicking expands to show all replies. Main comments remain visible. Resolves ENG-515 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Fix prettier formatting in spec file (multi-line function params) - Replace for...of loop with reduce to satisfy no-restricted-syntax rule Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

vercel · 2026-01-30T13:46:40Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
daily-webapp	Ready	Preview	Jan 30, 2026 2:33pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
storybook	Ignored		Jan 30, 2026 2:33pm

CLAassistant · 2026-01-30T13:46:43Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ rebelchris
❌ daily.dev Bot

daily.dev Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…tion-to-minimize

rebelchris · 2026-01-30T13:54:05Z

@claude Have another look please, we already added something, it should just be expanded by default, and when minimized show 3 avatars + amount of comments.

claude · 2026-01-30T13:54:22Z

Claude finished @rebelchris's task in 5m 27s —— View job

Changes completed

Read current implementation
Understand the default state logic
Invert logic to make expanded the default
Use CollapsedRepliesPreview component when collapsed
Update tests
Run linter
Commit and push changes

Summary

I've updated the comment behavior to match your requirements:

What changed:

Expanded by default - Replies now show expanded by default instead of collapsed
CollapsedRepliesPreview component - When users click "Hide replies", they now see the proper preview component with:
- Up to 3 overlapping user avatars
- "View X replies" text
Updated tests - All tests now reflect the new behavior

Files modified:

MainComment.tsx - Changed default state and integrated CollapsedRepliesPreview component
MainComment.spec.tsx - Updated all tests to match new behavior

The linter passed successfully, and changes have been pushed to the branch.

--- |

…mized - Changed default state to expanded (useState(true)) - Replaced simple button with CollapsedRepliesPreview component showing 3 avatars + count - Updated tests to reflect new behavior - Removed unused state variables Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>

rebelchris

@claude see comments

rebelchris · 2026-01-30T14:07:11Z

packages/shared/src/components/comments/CollapsedRepliesPreview.tsx

+    <button
+      type="button"
+      className={classNames(
+        'flex w-full cursor-pointer items-center gap-2 px-4 py-3 hover:bg-surface-hover',


this should also be rounded-16 make sure to follow lint rules for order.

rebelchris · 2026-01-30T14:07:43Z

packages/shared/src/components/comments/CollapsedRepliesPreview.tsx

+
+const MAX_AVATARS = 3;
+
+export default function CollapsedRepliesPreview({


This component should not render if no sub comments.

claude · 2026-01-30T14:09:46Z

Claude finished @dailydotdevbot's task in 4m 59s —— View job

Changes completed

Read CollapsedRepliesPreview.tsx
Fix rounded-16 class order on line 44
Add guard clause to prevent rendering with no sub comments
Update tests if needed
Run linter
Commit and push changes

Summary

I've addressed both review comments:

1. Added rounded-16 to button (packages/shared/src/components/comments/CollapsedRepliesPreview.tsx:48)

Added rounded-16 class to the button with proper class order following lint rules

2. Guard clause for empty replies (packages/shared/src/components/comments/CollapsedRepliesPreview.tsx:20)

Component now returns null when there are no sub comments
Moved the early return after hooks to comply with React's rules of hooks
Added test case to verify this behavior

Additional fixes:

Fixed React hooks rules violation by restructuring the component
Updated test to use proper Testing Library methods (queryByRole instead of direct DOM access)
All lint checks pass successfully

Changes have been committed and pushed to the branch.

--- | View commit

…with no replies - Add rounded-16 class to button with proper class order - Add guard clause to return null when no replies exist - Fix React hooks rules violation by moving useMemo before early return - Update test to use proper testing library methods Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>

rebelchris · 2026-01-30T14:26:55Z

@claude I still see "Hide replies" button when there are no replies.

claude · 2026-01-30T14:27:12Z

Claude finished @rebelchris's task in 2m 54s —— View job

Changes completed

Read MainComment.tsx to understand current implementation
Fix "Hide replies" button to only show when replies exist
Update tests if needed
Run linter
Commit and push changes

Summary

Fixed the issue where the "Hide replies" button was showing even when there were no replies to hide.

What changed:

Added replyCount > 0 condition to the "Hide replies" button rendering logic in MainComment.tsx:182
Added a test case to verify the button doesn't appear when there are no replies
All lint checks pass successfully

The "Hide replies" button will now only show when there are actually replies to hide.

View commit

Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>

daily.dev Bot and others added 2 commits January 30, 2026 13:28

fix: lint errors in CollapsedRepliesPreview

ab1da92

- Fix prettier formatting in spec file (multi-line function params) - Replace for...of loop with reduce to satisfy no-restricted-syntax rule Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

dailydotdevbot requested a review from a team as a code owner January 30, 2026 13:46

dailydotdevbot requested review from AmarTrebinjac, capJavert, omBratteng and rebelchris January 30, 2026 13:46

vercel bot deployed to Preview – daily-webapp January 30, 2026 13:50 View deployment

Merge branch 'main' into eng-515-comments-expanded-by-default-with-op…

1af4b53

…tion-to-minimize

vercel bot deployed to Preview – daily-webapp January 30, 2026 13:57 View deployment

vercel bot deployed to Preview – daily-webapp January 30, 2026 14:03 View deployment

rebelchris reviewed Jan 30, 2026

View reviewed changes

vercel bot deployed to Preview – daily-webapp January 30, 2026 14:18 View deployment

fix: only show 'Hide replies' button when replies exist

e261d5d

Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>

vercel bot deployed to Preview – daily-webapp January 30, 2026 14:33 View deployment

rebelchris approved these changes Jan 30, 2026

View reviewed changes

rebelchris merged commit 26280e0 into main Jan 30, 2026
10 of 11 checks passed

rebelchris deleted the eng-515-comments-expanded-by-default-with-option-to-minimize branch January 30, 2026 14:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(comments): collapse sub-comments by default with expand preview#5420

feat(comments): collapse sub-comments by default with expand preview#5420
rebelchris merged 6 commits intomainfrom
eng-515-comments-expanded-by-default-with-option-to-minimize

dailydotdevbot commented Jan 30, 2026 •

edited by github-actions bot

Loading

Uh oh!

vercel bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

CLAassistant commented Jan 30, 2026 •

edited

Loading

Uh oh!

rebelchris commented Jan 30, 2026

Uh oh!

claude bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

rebelchris left a comment

Uh oh!

rebelchris Jan 30, 2026

Uh oh!

rebelchris Jan 30, 2026

Uh oh!

claude bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

rebelchris commented Jan 30, 2026

Uh oh!

claude bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		const MAX_AVATARS = 3;

		export default function CollapsedRepliesPreview({

Conversation

dailydotdevbot commented Jan 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Preview domain

Uh oh!

vercel bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rebelchris commented Jan 30, 2026

Uh oh!

claude bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes completed

Summary

Uh oh!

rebelchris left a comment

Choose a reason for hiding this comment

Uh oh!

rebelchris Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

rebelchris Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes completed

Summary

Uh oh!

rebelchris commented Jan 30, 2026

Uh oh!

claude bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes completed

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dailydotdevbot commented Jan 30, 2026 •

edited by github-actions bot

Loading

vercel bot commented Jan 30, 2026 •

edited

Loading

CLAassistant commented Jan 30, 2026 •

edited

Loading

claude bot commented Jan 30, 2026 •

edited

Loading

claude bot commented Jan 30, 2026 •

edited

Loading

claude bot commented Jan 30, 2026 •

edited

Loading