Skip to content

fixed #14619/#14620 - fixed potential memory leak using --rule / suppressed valgrind false positive #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
firewave wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −5
Open

fixed #14619/#14620 - fixed potential memory leak using --rule / suppressed valgrind false positive #8365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d21ec4
fixed #14619 - fixed potential memory leak using `--rule`
firewave Mar 22, 2026
e10016f
valgrind.yml: run `TestRegEx`
firewave Mar 22, 2026
92b177a
removed LSAN suppression
firewave Mar 22, 2026
6aa292b
fixed #14620 - add suppression for valgrind false positive
firewave Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/asan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
env:
QT_VERSION: 6.10.0
ASAN_OPTIONS: detect_stack_use_after_return=1
LSAN_OPTIONS: suppressions=lsan-suppr.txt:print_suppressions=0
# TODO: figure out why there are cache misses with PCH enabled
CCACHE_SLOPPINESS: pch_defines,time_macros

Expand Down Expand Up @@ -100,7 +99,6 @@ jobs:

- name: Run CTest
run: |
cp lsan-suppr.txt cmake.output/bin
ctest --test-dir cmake.output --output-on-failure -j$(nproc)

- name: Run test/cli
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/valgrind.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Run valgrind
run: |
ec=0
valgrind --error-limit=yes --leak-check=full --num-callers=50 --show-reachable=yes --track-origins=yes --suppressions=valgrind/testrunner.supp --gen-suppressions=all --log-fd=9 --error-exitcode=42 ./testrunner TestGarbage TestOther TestSimplifyTemplate 9>memcheck.log || ec=1
valgrind --error-limit=yes --leak-check=full --num-callers=50 --show-reachable=yes --track-origins=yes --suppressions=valgrind/testrunner.supp --gen-suppressions=all -s --log-fd=9 --error-exitcode=42 ./testrunner TestGarbage TestOther TestSimplifyTemplate TestRegEx 9>memcheck.log || ec=1
cat memcheck.log
exit $ec
# TODO: debuginfod.ubuntu.com is currently not responding to any requests causing it to run into a 40(!) minute timeout
Expand Down
2 changes: 1 addition & 1 deletion lib/regex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ namespace {
~PcreRegex() override
{
if (mExtra) {
pcre_free(mExtra);
pcre_free_study(mExtra);
mExtra = nullptr;
}
if (mRe) {
Expand Down
1 change: 0 additions & 1 deletion lsan-suppr.txt
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions valgrind/testrunner.supp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,9 @@
obj:*
obj:*
}
{
TestRegEx::partialmatch false positive
Memcheck:Cond
obj:*
obj:*
}
Loading