Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThe pull request removes no-std build verification from CI by deleting the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #522 +/- ##
=============================================
- Coverage 66.90% 66.86% -0.05%
=============================================
Files 313 313
Lines 64757 64765 +8
=============================================
- Hits 43325 43303 -22
- Misses 21432 21462 +30
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
4fd4913 to
d27d96a
Compare
d27d96a to
8364cd0
Compare
xdustinface
left a comment
There was a problem hiding this comment.
I agree with removing the dangling std features for wallet where it only pretends to support it but why do you want to remove the fully supported and tested std feature flags in other crates?
I dont know if i am forgetting something or i am removing more than what I should
Summary by CodeRabbit