Enable export substitution for _version.py#8709
Open
Conversation
I'm not sure why this was missed, but when you install versioneer, it adds these attributes so that things like version/commit hash/etc. are correct when you make a git archive. Without this substitution, `test_git_revision` fails because there is no revision info in the archive tarball.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ± 0 29 suites ±0 10h 11m 57s ⏱️ - 1h 20m 22s For more details on these failures and errors, see this check. Results for commit e135b0a. ± Comparison against base commit aeebb2d. This pull request removes 8 and adds 13 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why this was missed, but when you install versioneer, it adds these attributes so that things like version/commit hash/etc. are correct when you make a git archive. Without this substitution,
test_git_revisionfails because there is no revision info in the archive tarball.pre-commit run --all-files