Move parseResourcesState() Name-vs-ID logic to data#4521
Closed
simonfaltum wants to merge 3 commits intomainfrom
Closed
Move parseResourcesState() Name-vs-ID logic to data#4521simonfaltum wants to merge 3 commits intomainfrom
simonfaltum wants to merge 3 commits intomainfrom
Conversation
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 704bb20
32 interesting tests: 12 FAIL, 7 KNOWN, 7 flaky, 5 RECOVERED, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Replace the switch statement's name-based cases with a nameBasedStateResources map, so adding a new Name-based resource only requires adding one entry to the set instead of editing the switch. permissions, grants, and dashboards retain their explicit branches since they have unique logic beyond just choosing Name vs ID. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonfaltum
force-pushed
the
simonfaltum/state-parsing-to-data
branch
from
1ab6d0c to
883f446
Compare
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseResourcesState()with a data-drivennameBasedStateResourcessetpermissions,grants, anddashboardsspecial cases remain explicit (unique logic)Test plan
go test ./bundle/deploy/terraform/...passes🤖 Generated with Claude Code