Move GroupToTerraformName to per-converter declarations#4522
Closed
simonfaltum wants to merge 3 commits intomainfrom
Closed
Move GroupToTerraformName to per-converter declarations#4522simonfaltum wants to merge 3 commits intomainfrom
simonfaltum wants to merge 3 commits intomainfrom
Conversation
Each converter's init() now declares its Terraform resource name via registerConverter, eliminating the need for a centralized hardcoded map. GroupToTerraformName and TerraformToGroupName are built dynamically. Adding a new resource converter now automatically populates the TF name mapping without editing pkg.go. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: b2c8a31
31 interesting tests: 12 FAIL, 7 KNOWN, 6 flaky, 5 RECOVERED, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerConverterto accept the Terraform resource name alongside the converterGroupToTerraformNameandTerraformToGroupNamedynamically from converter registrationspermissionsandgrants(which don't have converters) are still handled explicitlyTest plan
go test ./bundle/deploy/terraform/...passesGroupToTerraformNameandTerraformToGroupNameproduce identical mappings🤖 Generated with Claude Code