Improve agentic coding infrastructure#4525
Merged
simonfaltum merged 6 commits intomainfrom Feb 17, 2026
Merged
Conversation
Add missing guardrails, patterns, and configuration that agents need to work effectively in this repo, based on patterns from the universe monorepo. Changes: - Add Common Mistakes, Error Handling, Generated Code, and Where to Put New Code sections to CLAUDE.md - Create .claude/settings.local.json with pre-approved safe operations (make, go test, git, gh pr) to reduce permission friction - Make CLAUDE.md the canonical file and AGENTS.md a symlink to it (single source of truth instead of maintaining two identical copies) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 4ace5c0
30 interesting tests: 16 KNOWN, 8 RECOVERED, 5 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Analyzed the last 25 merged PRs for reviewer feedback patterns and audited CI workflows against documentation. Key additions: - Pre-PR Checklist section documenting how to reproduce CI locally (CI runs fmtfull/lintfull, not the diff-only wrappers) - Go idioms from PR reviews: empty struct context keys, named constants for magic strings, source reference URLs - Table-driven test preference documented - New helper script gron.py added to acceptance test tools list - Additional anti-patterns from PR feedback: debug print statements, wrong way to run EnvMatrix variants, CI as source of truth for acceptance test output - "Why not what" commenting principle added to Development Tips Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Keep the original symlink direction: AGENTS.md is the source of truth (tool-agnostic name that works with all AI assistants), and CLAUDE.md symlinks to it. This matches the existing convention where .github/custom-instructions.md also points to AGENTS.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
denik
reviewed
Feb 17, 2026
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Feb 17, 2026
AGENTS.md
Outdated
Contributor
There was a problem hiding this comment.
We have something very similar above already.
- Remove diag.Diagnostics preference, use logdiag.LogDiag/LogError instead - Remove bundle/config/resources/ from generated code (not autogenerated) - Remove redundant Generated Code and Where to Put New Code sections - Remove Common Mistakes items already covered in other sections
simonfaltum
force-pushed
the
simonfaltum/improve-agentic-coding-infra
branch
from
2d2088d to
0ae06a1
Compare
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
- Remove go generate entry (not used in this repo) - Remove ajv note (unnecessary context about non-reproducible CI steps) - Remove acceptance test entries from Common Mistakes (duplicates content already in the Acceptance Tests section) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Feb 17, 2026
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Feb 17, 2026
| @@ -0,0 +1,38 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Claude docs recommend this file to be git ignored https://code.claude.com/docs/en/settings#configuration-scopes
should rename it to settings.json? @simonfaltum
pietern
added a commit
that referenced
this pull request
Feb 18, 2026
## Summary Rename `.claude/settings.local.json` to `.claude/settings.json`. This was added in #4525 under the incorrect file name. See https://code.claude.com/docs/en/settings#available-scopes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/settings.local.jsonwith pre-approved safe operations (make,go test,git,gh pr) — reduces agent permission frictionAGENTS.mdfrom a duplicate file to a symlink →CLAUDE.md(single source of truth)Based on a gap analysis comparing CLI's agentic infrastructure against the universe monorepo's patterns.
Test plan
.github/custom-instructions.md→../AGENTS.md→CLAUDE.mdchain works.claude/settings.local.jsonpermissions are appropriate🤖 Generated with Claude Code