Support volume_path in direct deploy engine#4611
Open
varundeepsaini wants to merge 1 commit intodatabricks:mainfrom
Open
Support volume_path in direct deploy engine#4611varundeepsaini wants to merge 1 commit intodatabricks:mainfrom
varundeepsaini wants to merge 1 commit intodatabricks:mainfrom
Conversation
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
denik
reviewed
Mar 11, 2026
| CloudEnvs.azure = false | ||
|
|
||
| [EnvMatrix] | ||
| DATABRICKS_BUNDLE_ENGINE = ["direct"] |
Contributor
There was a problem hiding this comment.
Why do we run this on direct only?
| type VolumeRemote struct { | ||
| catalog.VolumeInfo | ||
|
|
||
| VolumePath string `json:"volume_path,omitempty"` |
Contributor
There was a problem hiding this comment.
Why do we add this only on remote struct? This is something we can calculate from the local as well, right?
I wonder if we should just to config and evaluate early.
Signed-off-by: Varun Deep Saini <varun.23bcs10048@ms.sst.scaler.com>
varundeepsaini
force-pushed
the
ft/volume-path-support
branch
from
753c87e to
4f79a2b
Compare
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4233
Summary
volume_pathfield toVolumeRemotein the direct engine, matching the Terraform provider's behavior (/Volumes/{catalog}/{schema}/{name})${resources.volumes.foo.volume_path}interpolation without requiring the workaround of manually constructing the path from individual name componentsTest plan
makeVolumeRemote(full name and fallback paths)RemapStateexcludingvolume_pathfrom diff comparisonvolume_pathas REMOTE fieldvolume_pathvolume_pathreference0 to change)Tests written by Claude