Use resource.yml in field classification in config-remote-sync#4677
Open
ilyakuz-db wants to merge 6 commits intomainfrom
Open
Use resource.yml in field classification in config-remote-sync#4677ilyakuz-db wants to merge 6 commits intomainfrom
resource.yml in field classification in config-remote-sync#4677ilyakuz-db wants to merge 6 commits intomainfrom
Conversation
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 7957b55
15 interesting tests: 7 SKIP, 6 RECOVERED, 2 flaky
Top 36 slowest tests (at least 2 minutes):
|
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
commented
Mar 7, 2026
| email_notifications.on_failure[0]: replace | ||
| max_concurrent_runs: replace | ||
| tags['env']: remove | ||
| timeout_seconds: remove |
Contributor
Author
There was a problem hiding this comment.
This is expected, logic was incorrect previously - this case was skipped completely
ilyakuz-db
commented
Mar 7, 2026
| // If a CLI-defaulted field is changed on remote and should be disabled | ||
| // (e.g. queueing disabled → remote field is nil), we can't define it | ||
| // in the config as "null" because the CLI default will be applied again. | ||
| var resetValues = map[string][]resetRule{ |
Contributor
Author
There was a problem hiding this comment.
Should we include this logic in resources.yml?
ilyakuz-db
commented
Mar 7, 2026
| reason: managed | ||
|
|
||
| backend_defaults: | ||
| # Backend returns PERFORMANCE_OPTIMIZED for serverless jobs when not set |
Contributor
Author
There was a problem hiding this comment.
This is set only for serverless jobs, probably, this should live in changes desc overrides
Contributor
There was a problem hiding this comment.
Is this field ever set for non-serverless jobs?
ilyakuz-db
commented
Mar 7, 2026
|
|
||
| # Same as clusters.node_type_id — see clusters/resource_cluster.go#L333 | ||
| # s.SchemaPath("node_type_id").SetComputed() | ||
| - field: tasks[*].new_cluster.node_type_id |
Contributor
Author
There was a problem hiding this comment.
When I try to create new_cluster without node_type_id it fails with 400 error:
Endpoint: POST https://<host>/api/2.2/jobs/reset
HTTP Status: 400 Bad Request
API error_code: INVALID_PARAMETER_VALUE
API message: Cluster validation error: Unknown node type id
Considering that backend default is applied only when config value is nil, and for nil value we have 400 error - it doesn't make sense to keep it here
Contributor
There was a problem hiding this comment.
Question, if I don't specify new_cluster, can it be added by the backend when resource is fetched? I guess not, or some test would fail, but good to say it explicitly.
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
changed the title
resource.yml in field classification in config-remote-sync
ilyakuz-db
requested review from
andrewnester,
anton-107,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
denik
reviewed
Mar 9, 2026
| ignore_remote_changes: | ||
| # edit_mode is set by CLI, not user-configurable | ||
| - field: edit_mode | ||
| reason: managed |
Contributor
There was a problem hiding this comment.
I'm using "managed" in other places to mean managed by backend, we should have another reason here.
|
|
||
| jobs: | ||
| ignore_remote_changes: | ||
| # edit_mode is set by CLI, not user-configurable |
Contributor
There was a problem hiding this comment.
You mean DABs override user setting? Do you know if that is intentional?
| reason: managed | ||
|
|
||
| backend_defaults: | ||
| # Backend returns PERFORMANCE_OPTIMIZED for serverless jobs when not set |
Contributor
There was a problem hiding this comment.
Is this field ever set for non-serverless jobs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
resource.ymlclassification in config-remote-sync instead of custom rulesresource.ymlwith new fieldsWhy
This PR eliminates tech debt, config-remote-sync will be in sync with resource updates
Tests
Existing tests (one snapshot updated because underlying bug was fixed)