fix: update Apply pattern match arity in Materializer.hasSelfRefExpr#759
Closed
He-Pin wants to merge 1 commit intodatabricks:masterfrom
Closed
fix: update Apply pattern match arity in Materializer.hasSelfRefExpr#759He-Pin wants to merge 1 commit intodatabricks:masterfrom
He-Pin wants to merge 1 commit intodatabricks:masterfrom
Conversation
The auto-TCO PR (databricks#694) added a 'strict' boolean parameter to Apply, Apply0, Apply1, Apply2, and Apply3 case classes, but hasSelfRefExpr patterns were not updated, causing compilation failure on all Scala versions.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
Apply,Apply0–Apply3case classes gained an extratailstrictboolean field, but the pattern matches inMaterializer.hasSelfRefExprwere not updated to include the new field — causing a compilation failure on master.Modification
Updated pattern match arities for
Apply,Apply0,Apply1,Apply2, andApply3inMaterializer.hasSelfRefExprto include the additionaltailstrictboolean parameter.Result
Master compiles again. No behavioral change —
hasSelfRefExprwas already ignoring the tailstrict flag, and the wildcard_pattern correctly does the same.