Skip to content

PRG-03: Admin frontend (from #347)#367

Open
nap-liu wants to merge 1 commit intodataelement:mainfrom
nap-liu:prg/03-admin-frontend__from-p347
Open

PRG-03: Admin frontend (from #347)#367
nap-liu wants to merge 1 commit intodataelement:mainfrom
nap-liu:prg/03-admin-frontend__from-p347

Conversation

@nap-liu
Copy link
Copy Markdown

@nap-liu nap-liu commented Apr 10, 2026

This regrouped PR carries forward original PR #347.\n\nScope: admin user-management frontend updates only.

Add a modal component that allows admins to edit user display_name,
email, phone/mobile, reset password, and toggle is_active status.
The modal calls PATCH /api/users/{id}/profile. Each user row now has
an "Edit Info" button alongside the existing quota editor. Added
corresponding i18n keys for both en.json and zh.json.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

Thanks for the frontend update. I do not think we should merge this right now.

A couple of concrete issues:

  1. EditUserModal appears to be added but not wired into the page. I do not see new state or an action button that actually opens this modal, so the UI path seems incomplete.

  2. The modal saves to PATCH /api/users/{id}/profile, but the current users API exposes quota and role endpoints under /api/users, and the existing admin profile update path is different. As written, this save action would likely fail unless a matching backend endpoint is added.

More importantly, product-wise we do not want to expand admin-side editing of user personal information in the short term. For now, users should update their own profile information after logging in. Admin user management should stay focused on role/status/quota management unless we intentionally design a broader account-administration flow.

Could you close or revise this PR accordingly? If we revisit this later, it should come with a clear backend API design, permission model, and product decision for which fields admins are allowed to edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants