Skip to content

[CB] Reuse DnD from base grid component for Data Editor#4201

Merged
devnaumov merged 13 commits intodevelfrom
7159-cb-reuse-dnd-from-base-grid-component-for-data-editor
Mar 17, 2026
Merged

[CB] Reuse DnD from base grid component for Data Editor#4201
devnaumov merged 13 commits intodevelfrom
7159-cb-reuse-dnd-from-base-grid-component-for-data-editor

Conversation

@sergeyteleshev
Copy link
Contributor

@sergeyteleshev sergeyteleshev commented Mar 9, 2026

I tried to do it with the React-Data-Grid library, but it caused incorrect drag-and-drop behavior (and it seems like the issue is on the library's side). Plus, it breaks the dnd to the grouping panel

So I decided to stick with the current DnD implementation because it fits the one we have. Plus its unclear how to migrate, and the lack of resources

closes https://github.com/dbeaver/pro/issues/7159

@sergeyteleshev sergeyteleshev self-assigned this Mar 9, 2026
@sergeyteleshev sergeyteleshev marked this pull request as ready for review March 9, 2026 13:00
Wroud
Wroud previously approved these changes Mar 17, 2026
SychevAndrey
SychevAndrey previously approved these changes Mar 17, 2026
@sergeyteleshev sergeyteleshev dismissed stale reviews from Wroud and SychevAndrey via e030652 March 17, 2026 15:29
@devnaumov devnaumov merged commit 40385f3 into devel Mar 17, 2026
10 checks passed
@devnaumov devnaumov deleted the 7159-cb-reuse-dnd-from-base-grid-component-for-data-editor branch March 17, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants