Skip to content

fix(io): re-export public type aliases#6969

Merged
kt3k merged 1 commit intodenoland:mainfrom
jsejcksn:fix/io/export-types
Jan 30, 2026
Merged

fix(io): re-export public type aliases#6969
kt3k merged 1 commit intodenoland:mainfrom
jsejcksn:fix/io/export-types

Conversation

@jsejcksn
Copy link
Contributor

This PR re-exports type aliases used by parameters in exported functions — which the consumer would otherwise have to locate and import from a separate module.

For example, to include the parameter type WriterSync used by writeAllSync:

export function writeAllSync(writer: WriterSync, data: Uint8Array) {  }

Source

…before this PR the user would need to write:

import { writeAllSync } from "@std/io/write-all";
import type { WriterSync } from "@std/io/types";

…after the user would need to write:

import { writeAllSync, type WriterSync } from "@std/io/write-all";

Ref: Query for similar previous PRs from me

@jsejcksn jsejcksn requested a review from kt3k as a code owner January 25, 2026 00:00
@github-actions github-actions bot added the io label Jan 25, 2026
@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.08%. Comparing base (062aa94) to head (66bed62).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6969   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files         600      600           
  Lines       43553    43553           
  Branches     6997     6997           
=======================================
  Hits        40977    40977           
  Misses       2521     2521           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit aa975c0 into denoland:main Jan 30, 2026
19 checks passed
@jsejcksn jsejcksn deleted the fix/io/export-types branch January 30, 2026 08:30
tomas-zijdemans pushed a commit to tomas-zijdemans/std_cb that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants