Issue#16 one var#23
Open
Kapnobatai3434 wants to merge 3 commits intodeployd:masterfrom
Kapnobatai3434:issue#16_one-var
Open
Issue#16 one var#23Kapnobatai3434 wants to merge 3 commits intodeployd:masterfrom Kapnobatai3434:issue#16_one-var
Kapnobatai3434 wants to merge 3 commits intodeployd:masterfrom
Kapnobatai3434:issue#16_one-var
Conversation
Contributor
Author
|
Seems like this commit also fixes 'prefer const' eslint error |
Member
NicolasRitouet
left a comment
NicolasRitouet
left a comment
There was a problem hiding this comment.
Good PR, just remove the line and the file and it's good to be merged 👍
.eslintrc.js
Outdated
| "no-unused-vars": 1, // 3 errors | ||
| "no-use-before-define": 1, // 7 errors | ||
| "one-var": 1, // 8 errors | ||
| "one-var": 2, // 8 errors |
Member
There was a problem hiding this comment.
You can remove the line completely and it will use the default value from airbnb-base (which is error also)
package-lock.json
Outdated
| @@ -0,0 +1,4363 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
same as the other PR, please, remove this file
lib/cli/start.js
Outdated
| let port = program.port; | ||
| const host = program.host || '127.0.0.1'; | ||
| const dbname = program.dbname || '-deployd'; | ||
| let mongoPort = '27017'; |
Member
There was a problem hiding this comment.
Once your other PR has been merged, you can change this into const
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed eslint errors for 'one-var' rule
Description
3 files needed changes. In which some variables needed their own declaration
Motivation and Context
It was requested by NicolasRitouet
#16
How Has This Been Tested?
npm run test command
the code was tested using jest
Screenshots (if appropriate):
Types of changes
Checklist: