[ethers-v5] Separate import and type import#737
Open
noy4 wants to merge 2 commits intodethcrypto:masterfrom
Open
[ethers-v5] Separate import and type import#737noy4 wants to merge 2 commits intodethcrypto:masterfrom
noy4 wants to merge 2 commits intodethcrypto:masterfrom
Conversation
|
|
@krzkaczor do you see any issues with this PR? |
|
Any ETA when this can be merged? I'll gladly help if there is some code needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes:
I faced a same problem with this Issue: #732
This problem for contract typings was fixed by this PR: #636, but not for contract factory (maybe it was left out).
I simply turned everything in ethers to be imported with
import typeinSome__factory.ts, but faced another problem↓So, I separated
importandimport typefor ethers.