Skip to content

Conversation

@akurinnoy
Copy link
Collaborator

@akurinnoy akurinnoy commented Dec 29, 2025

What does this PR do?

This PR fixes the debug mode e2e test: waits the test devworkspace for Running status instead of Starting. Also, is adds the AfterEach cleanup step to prevent PVC conflicts.

What issues does this PR fix or reference?

#1569

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@openshift-ci
Copy link

openshift-ci bot commented Dec 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Dec 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, rohanKanojia
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia
Copy link
Member

Thanks a lot for the fix! Do you think it fixes #1535 ?

@rohanKanojia
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test and removed lgtm labels Dec 30, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2026

New changes are detected. LGTM label has been removed.

@akurinnoy
Copy link
Collaborator Author

/retest

2 similar comments
@rohanKanojia
Copy link
Member

/retest

@dkwon17
Copy link
Collaborator

dkwon17 commented Jan 9, 2026

/retest

@akurinnoy
Copy link
Collaborator Author

/retest

@akurinnoy
Copy link
Collaborator Author

/retest

@akurinnoy akurinnoy marked this pull request as ready for review January 15, 2026 13:17
- Add ControllerRuntimeClient() method to test client for accessing CRDs
- Add controllerv1alpha1 to scheme for DWOC access
- Add DWOC save/restore in BeforeAll/AfterAll to prevent config leaks
- Use ginkgo.Ordered to ensure sequential test execution
- Update copyright year to 2026

This prevents config leaks between custom init container tests and ensures
clean state for each test run.

Assisted-by: Claude Sonnet 4.5
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants