chore: add new java quarkus devfile version based on ubi9/openjdk-21#657
Conversation
|
Hi @vinokurig. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@vinokurig: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test /retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
@thepetk hello, could you please take a look at the failed PR check? It doesn’t seem to be related to the current changes. |
|
/retest @vinokurig yeah I agree, there's an open issue we're currently working at. I'm going to retest one more time to see if there's anything wrong and then I'll approve merge. |
There was a problem hiding this comment.
/lgtm
@michael-valdron I think we could merge this one, I just don't have the perms to by-pass the ruleset.
|
/retest |
|
FYI @vinokurig @ibuziuk @svor I'll merge this, however the enterprise contract is currently failing across our devfile registry components, this check will block this change going to the deployments, I'll address fixing this ASAP to unblock this and once fixed I'll merge #659 konflux patch to trigger the deployment with these changes. cc @thepetk |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@vinokurig You'll need to amend sign off your commit, just noticed the DCO didn't catch this 🤔
|
/retest |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
FYI @vinokurig @ibuziuk @svor
I'll merge this, however the enterprise contract is currently failing across our devfile registry components, this check will block this change going to the deployments, I'll address fixing this ASAP to unblock this and once fixed I'll merge #659 konflux patch to trigger the deployment with these changes.
cc @thepetk
@vinokurig You'll need to amend sign off your commit, just noticed the DCO didn't catch this 🤔
@vinokurig I've fixed the EC checks, after you amend the sign off in your commit and rebase you should be good to merge 👍
Signed-off-by: Ihor Vinokur <ivinokur@redhat.com>
vinokurig
force-pushed
the
fix-java-quarkus
branch
from
0482332 to
c2739a6
Compare
|
/retest |
1 similar comment
|
/retest |
|
/ok-to-test |
|
@michael-valdron we still have problems with PR checks |
|
/ok-to-test |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@michael-valdron we still have problems with PR checks
@svor Devfile / Check devfile registry odo V3 build & deploy (pull_request) and ci/prow/v4.16-images are expected to fail.
Devfile / Check devfile registry odo V3 build & deploy (pull_request)
This check is just related to the root devfile to deploy the registry and not related to these changes. Failure here is that the Docker API has changed recently to a newer one that isn't compatible with our Kubernetes version being used and had to pin the version for another workflow of ours: https://github.com/devfile/registry-support/blob/d43ddf108c1027506f0d38ec4a517ca8353d689d/.github/workflows/ci.yaml#L26
This has been ongoing failing for us and we're still trying to fix this, for now we've been doing manual testing to check this and overriding the merge if everything is good.
I did check with DevSpaces on OpenShift, the workspace opened and was able to run the tasks. Side note is that I did run into an error with the run and debug commands due to it restricting to localhost but other than that seems to work as expected.
Additionally I did run integration tests manually, only run into an error with nodejs-mongodb due to bitnami/mongodb removing the 8.0.8 tag 😒.. but in the context for these changes looks good to me ✔️
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibuziuk, michael-valdron, thepetk, vinokurig The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
@vinokurig: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
Description of Changes
mvncommand instead of the./mvnwwrapper scriptThe
./nvmwwrapper script fails to untar the downloaded maven binaries because the requiredtargztool is missing in the openjdk container. To fix that we call maven directly. Theubi9/openjdk-21container contains the proper maven version which is compatible withquarkus.Related Issue(s)
fixes eclipse-che/che#23651
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.