dhi guides: securing a backstage portal using DHI#24359
Merged
craig-osterhout merged 12 commits intodocker:mainfrom Mar 17, 2026
Merged
dhi guides: securing a backstage portal using DHI#24359craig-osterhout merged 12 commits intodocker:mainfrom
craig-osterhout merged 12 commits intodocker:mainfrom
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ajeetraina
changed the title
usha-mandya
reviewed
Mar 13, 2026
Member
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
Assessment: 🟡 NEEDS ATTENTION
This is a comprehensive and well-structured guide for securing Backstage with Docker Hardened Images. The technical content is accurate and the guide demonstrates strong knowledge of multi-stage builds, native module compilation, and DHI customizations.
However, there are several style guide violations that should be addressed:
Critical Issues (2):
- Hedge word "making it easy" violates the style guide's prohibition on marketing language
- Time-relative language "soon" should be removed or replaced with specific information
Notable Issues (4):
- SEO description exceeds the recommended 150-160 character limit (177 chars)
- Content contradiction: The Important callout says not to add language runtimes as system packages, but the example immediately adds Python as a system package
- Meta-commentary "This is expected" should be stated directly
Findings
See inline comments for specific recommendations.
Reworded the description of the `dhictl` CLI for clarity.
Clarified the usage of `dhictl` and added a reference for installation instructions.
craig-osterhout
approved these changes
Mar 16, 2026
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
LGTM.
Left some non-blocking nits.
Clarify the DHI Node.js image variants and installation commands.
Contributor
Author
|
@craig-osterhout I have made all the necessary changes. Pls do check it once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a guide that shows how to secure a Backstage developer portal container using Docker Hardened Images, covering native module compilation, multi-stage builds, Socket Firewall protection, and distroless runtime images
Related issues or tickets
Reviews