guides: update rust guide#24386
Merged
craig-osterhout merged 1 commit intodocker:mainfrom Mar 17, 2026
Merged
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
The changes correctly remove unnecessary user creation steps from the Docker Hardened Image (DHI) Dockerfile example. The dhi.io/static:20250419 base image runs as a nonroot user by default and lacks the adduser package, making the removed code both incorrect and impossible to execute.
Summary
What was changed:
- Removed
addusercommand andUSER appuserinstruction from the DHI Dockerfile example
Why this is correct:
- DHI static images run as nonroot by default (no manual user creation needed)
- The static image doesn't include the
adduserpackage (the removed code would fail) - This aligns with documented DHI behavior
Documentation quality:
- No issues introduced by this PR
- The change improves accuracy by removing incorrect instructions
- Scope is appropriate (targeted fix, no unnecessary expansion)
Findings
No issues found in the changed code. The PR correctly addresses issue #24362.
Note: One pre-existing formatting issue was observed in the comment at line 119 (broken line with stray # symbols), but this was not introduced by this PR and doesn't block approval.
dvdksn
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The DHI static image has no adduser package, plus it already runs as a nonroot user. Removed that section from the Dockerfile.
Related issues or tickets
Closes #24362
Reviews