Open
Conversation
slug.js
Outdated
|
|
||
| function slug(string, opts) { | ||
| string = string.toString(); | ||
| string = (string || '').toString(); |
Author
There was a problem hiding this comment.
Maybe it would be more semantic to just have the function return null or undefined if the string is null or undefined?
Contributor
There was a problem hiding this comment.
In my opinion, null and undefined should be considered a developer mistake and throw.
if (string === null || string === undefined)
throw new Error('input must be castable to string')
Author
There was a problem hiding this comment.
Good point. Should it throw for anything other than a string?
benvmatheson
changed the title
|
I'd argue null or undefined as slugified should exactly an empty string. I think throwing on this would generally cause more issues than help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If undefined is passed in, this will return an empty string instead of an error. Not sure if this error is preferred to just returning an empty string though.